Consolidation features 'What's New' & 'Paste html to govspeak' #2091
Conversation
CL-GDS
force-pushed
the
consolidation-main
branch
from
072fe42
to
8713c98
Compare
What Extended manuals _form.html.erb textareas to js-paste-html-to-govspeak class Extended sections _form.html.erb textareas to js-paste-html-to-govspeak class Extended application.js to have a function to apply pasteHtmlToGovspeak.pasteListener to js-paste-html-to-govspeak class Extended package.json to install the NPM package Why Implement paste-html-to-govspeak function to textareas on forms so users can paste HTML into them and it convert to govspeak to speed creating and editing
What Extend creating-and-editing-a-manual.feature by adding senario to test pasting HTML into a _form used by a manual. Extended manual_steps.rb by adding 'When' with variable field
What Added design system layout and CSS Added whats new index page linked to a yaml for translation Added back to top for whats-new page Added type for whats new page Added updates for whats new page Extended application js with the components used Extended application css with the components used and a class for the govspeak text as colour error when importing Added govuk js as described in design system setup guide Extended pacakge with front end and dart as described in the setup guide Extended routes to path whats_new to /whats-new Added controller for whats-new Why Alert users to the features that the consolidation team is adding. Starts as a base for the design system so other pages can be added easily. Emulate as close to the look of Whitehall whats-new page, getting error of colour grey when importing govspeak following the guide so have emulated it in a class
CL-GDS
force-pushed
the
consolidation-main
branch
from
8713c98
to
93af166
Compare
|
I don't really understand why we've merged the paste-html-to-govspeak branch into this as it doesn't seem coupled? There's a few odd things in the design system commit that'd be good to work out in a distinct PR, it might be worth having a chat. I'm also wondering if we really want a "what's new" page if it's likely not to be updated much after this month? Won't it feel rather stale? Might be good to have a chat before proceeding further |
the merge into consolidation-main branch was probably my fault, miscommunication as i went on leave before last week: having picked back up, we were also thinking to split back to 2 PRs to main - look like you're at away day today hopefully quick chat to resolve in morning (i've pinged Ahmed re: utility/value of what's new) |
|
Closing PR as we have split into two separate PRs:
|
Includes PR #2083
What
setup guide: https://frontend.design-system.service.gov.uk/
Added design system layout and CSS
Added whats new index page linked to a yaml for translation Added back to top for whats-new page
Added type for whats new page
Added updates for whats new page
Extended application js with the components used
Extended application css with the components used and a class for the govspeak text as colour error when importing Added govuk js as described in design system setup guide Extended pacakge with front end and dart as described in the setup guide Extended routes to path whats_new to /whats-new
Added controller for whats-new
Why
Alert users to the features that the consolidation team is adding. Starts as a base for the design system so other pages can be added easily. Emulate as close to the look of Whitehall whats-new page, getting error of colour grey when importing govspeak component when following the setup guide so have emulated it in a class. Added all_components to JS as we will be replacing pages we can add single components.
Merge the features previously added to move forward with a release plan with branches based from main
Trello
https://trello.com/c/yJcgYJS7/340-manuals-improvement-comms
Pics
Follow these steps if you are doing a Rails upgrade.